Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepts Article object #4499

Merged
merged 1 commit into from Mar 14, 2019
Merged

Accepts Article object #4499

merged 1 commit into from Mar 14, 2019

Conversation

mei23
Copy link
Contributor

@mei23 mei23 commented Mar 14, 2019

Summary

Resolve #4498

  • Accepts AP object Article. (like a `Note)
  • Save property name of AP.
  • Send name as title to client.

WriteFreelyから送られてくるArticleを保存するようにしています
Article=multi-paragraph, Note=single-paragraph みたいな定義らしいですが、
どちらもほぼ同じと思われるためNote扱いで受け取ってます。

またnameとしてblogのタイトルを送ってくるようなので
とりあえずnameとして保存して、pack時にMFMタイトルとして送るようにしています。

細かい書式はともかく、とりあえずpullで取得できることは確認しています。
image

Copy link
Member

@syuilo syuilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@syuilo syuilo merged commit 56eb896 into misskey-dev:develop Mar 14, 2019
@syuilo
Copy link
Member

syuilo commented Mar 14, 2019

ありがとうございます🙏

@mei23 mei23 deleted the mei-90315-article branch October 11, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants